Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/rees_algebra): Define the Rees algebra of an ideal. #15089

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(ring_theory/rees_algebra): Define the Rees algebra of an ideal. #15089

wants to merge 5 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jul 2, 2022

Open in Gitpod

@erdOne erdOne added the awaiting-review The author would like community review of the PR label Jul 2, 2022
Vierkantor
Vierkantor reviewed Jul 12, 2022
View reviewed changes
src/ring_theory/rees_algebra.lean Outdated Show resolved Hide resolved
src/ring_theory/rees_algebra.lean Outdated Show resolved Hide resolved
src/ring_theory/rees_algebra.lean Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 12, 2022
erdOne and others added 3 commits July 12, 2022 21:50
@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 12, 2022
Vierkantor
Vierkantor approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 13, 2022
bors bot pushed a commit that referenced this pull request Jul 13, 2022
@erdOne
feat(ring_theory/rees_algebra): Define the Rees algebra of an ideal. (#…
053b49b 
…15089)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 13, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 13, 2022
@erdOne
feat(ring_theory/rees_algebra): Define the Rees algebra of an ideal. (#…
2dfa69c 
…15089)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 13, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/rees_algebra): Define the Rees algebra of an ideal. [Merged by Bors] - feat(ring_theory/rees_algebra): Define the Rees algebra of an ideal. Jul 13, 2022
@bors bors bot closed this Jul 13, 2022
@bors bors bot deleted the rees_algebra branch July 13, 2022 13:55
joelriou pushed a commit that referenced this pull request Jul 23, 2022
@erdOne @joelriou
feat(ring_theory/rees_algebra): Define the Rees algebra of an ideal. (#…
4881ff4 
…15089)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erdOne @eric-wieser @Vierkantor @leanprover-community-bot-assistant