Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/bezout): Define Bézout rings. #15091

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(ring_theory/bezout): Define Bézout rings. #15091

wants to merge 7 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jul 2, 2022

Open in Gitpod

@erdOne erdOne added the awaiting-review The author would like community review of the PR label Jul 2, 2022
Vierkantor
Vierkantor approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

bors d+

src/ring_theory/bezout.lean Outdated Show resolved Hide resolved
src/ring_theory/bezout.lean Outdated Show resolved Hide resolved
src/ring_theory/bezout.lean Outdated Show resolved Hide resolved
src/ring_theory/bezout.lean Outdated Show resolved Hide resolved
src/ring_theory/bezout.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 12, 2022

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 12, 2022
erdOne and others added 3 commits July 13, 2022 03:56
@erdOne @Vierkantor
Apply suggestions from code review
0dea875 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@erdOne
rename gcd_prop to span_gcd
69dfeec
@erdOne
rename of_surjective
81fbe1c
@erdOne
Copy link
Member Author

erdOne commented Jul 12, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 12, 2022
@erdOne
feat(ring_theory/bezout): Define Bézout rings. (#15091)
3543262 


Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 13, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/bezout): Define Bézout rings. [Merged by Bors] - feat(ring_theory/bezout): Define Bézout rings. Jul 13, 2022
@bors bors bot closed this Jul 13, 2022
@bors bors bot deleted the bezout_domain branch July 13, 2022 00:00
joelriou pushed a commit that referenced this pull request Jul 23, 2022
@erdOne @joelriou
feat(ring_theory/bezout): Define Bézout rings. (#15091)
1f61712 


Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erdOne @Vierkantor @leanprover-community-bot-assistant