[Merged by Bors] - feat(number_theory/modular_forms/congruence_subgroups): Add definition of congruence subgroups. #15159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of congruence subgroups and basic examples.
CBirkbeck
changed the title
CBirkbeck
added
awaiting-review
CBirkbeck
added
WIP
CBirkbeck
added
awaiting-review
| @@ -209,6 +209,29 @@ subtype.ext $ (@ring_hom.map_matrix n _ _ _ _ _ _ (int.cast_ring_hom R)).map_neg | |||
|
|
|||
| end has_neg | |||
|
|
|||
| section special_cases | |||
|
|
|||
| lemma SL2_inv_det_expl (A : SL(2,R)) : det ![![A.1 1 1, -A.1 0 1], ![-A.1 1 0 , A.1 0 0]] = 1 := | |||
There was a problem hiding this comment.
I don't understand the name...
There was a problem hiding this comment.
Ok so I think what I meant to call this is SL2_inv_expl_det for the det of the explicit inverse. But its not a great name, I'm happy to change it to something else. I guess maybe the SL isn't needed...
…community/mathlib into congruence_subgroups
alexjbest
reviewed
Sep 1, 2022
riccardobrasca
approved these changes
Sep 5, 2022
done! |
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
…n of congruence subgroups. (#15159) This contains the definition of a congruence subgroup of `SL(2,Z)` and defines Gamma1, Gamma0 and full level subgroups. It also contains some basic results about them.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bottine
pushed a commit
that referenced
this pull request
Sep 13, 2022
…n of congruence subgroups. (#15159) This contains the definition of a congruence subgroup of `SL(2,Z)` and defines Gamma1, Gamma0 and full level subgroups. It also contains some basic results about them.
b-mehta
pushed a commit
that referenced
this pull request
Sep 21, 2022
…n of congruence subgroups. (#15159) This contains the definition of a congruence subgroup of `SL(2,Z)` and defines Gamma1, Gamma0 and full level subgroups. It also contains some basic results about them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the definition of a congruence subgroup of
SL(2,Z)and defines Gamma1, Gamma0 and full level subgroups. It also contains some basic results about them.