Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/list/to_finsupp): computable finsupp from list #15161

Closed
wants to merge 30 commits into from
Closed

[Merged by Bors] - feat(data/list/to_finsupp): computable finsupp from list #15161

wants to merge 30 commits into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented Jul 7, 2022 •
edited by github-actions bot

pechersky and others added 11 commits July 6, 2022 00:22
@pechersky
feat(data/list/nthd): accessing list with fallback
bf2ae1d 
Also prove some things about `list.inth` on the way.
On the way to computable list-based polynomials
@pechersky
feat(data/list/basic): nth_le_enum
6819172 
Fill out some of the `enum` and `enum_from` API
Link the two via `map_fst_add_enum_eq_enum_from`.
@pechersky
feat(data/finsupp/big_operators): sum of finsupp and their support
7d89ad6 
With some additional API for pairwise on multisets and coerced lists
On the way to computable list-based polynomials
@pechersky
Fix curly braces style
f2aed19
@pechersky
Merge branch 'pechersky/list-nthd' into pechersky/list-to-finsupp
9a65269
@pechersky
Merge branch 'pechersky/list-enum-api' into pechersky/list-to-finsupp
b4568f9
@pechersky
rfl enum lemmas, generalize map_enum_from lemma
911dade
@pechersky
lint def to lemma properly
c724798
@pechersky
feat(data/list/to_finsupp): computable finsupp from list
8390381 
via `list.nthd`
@pechersky
Merge remote-tracking branch 'origin/pechersky/sum-finsupp-support' i…
0498aa1 
…nto pechersky/list-to-finsupp
@pechersky
Merge remote-tracking branch 'origin/pechersky/list-enum-api' into pe…
9dcab6e 
…chersky/list-to-finsupp
@pechersky pechersky added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jul 7, 2022
eric-wieser
eric-wieser reviewed Jul 9, 2022
View reviewed changes
src/data/list/nthd.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Jul 9, 2022
View reviewed changes
src/data/list/perm.lean Outdated Show resolved Hide resolved
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 9, 2022
@eric-wieser
Copy link
Member

On the way to computable list-based polynomials

If we're truly after computability for polynomials, could we just define them with dfinsupp?

@pechersky
Copy link
Collaborator Author

If we're truly after computability for polynomials, could we just define them with dfinsupp?

Do you mean change the underlying implementation for polynomial?

@pechersky pechersky mentioned this pull request Jul 17, 2022
Open
2 tasks
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 20, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@pechersky pechersky removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 12, 2023
YaelDillies
YaelDillies reviewed Feb 13, 2023
View reviewed changes
src/data/list/to_finsupp.lean Outdated Show resolved Hide resolved
src/data/list/to_finsupp.lean Show resolved Hide resolved
src/data/list/to_finsupp.lean Show resolved Hide resolved
YaelDillies
YaelDillies approved these changes Feb 27, 2023
View reviewed changes
src/data/list/to_finsupp.lean Outdated Show resolved Hide resolved
@YaelDillies
Copy link
Collaborator

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@semorrison semorrison added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Mar 26, 2023
Vierkantor
Vierkantor approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

bors d+

src/data/list/to_finsupp.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 27, 2023

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 27, 2023
@pechersky
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 5, 2023
@pechersky @YaelDillies
feat(data/list/to_finsupp): computable finsupp from list (#15161)
06a655b 
via `list.nthd`
On the way to computable list-based polynomials



Co-authored-by: Yakov Pechersky <ffxen158@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@bors
Copy link

bors bot commented Apr 5, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/list/to_finsupp): computable finsupp from list [Merged by Bors] - feat(data/list/to_finsupp): computable finsupp from list Apr 5, 2023
@bors bors bot closed this Apr 5, 2023
@bors bors bot deleted the pechersky/list-to-finsupp branch April 5, 2023 18:16
@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Apr 6, 2023
Closed
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 6, 2023
@Ruben-VandeVelde
feat: port Data.Multiset.Basic change from mathlib3 (#3306)
3c23f5d 
See leanprover-community/mathlib#15161.
MonadMaverick pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 9, 2023
@Ruben-VandeVelde @MonadMaverick
feat: port Data.Multiset.Basic change from mathlib3 (#3306)
3f4277a 
See leanprover-community/mathlib#15161.
MonadMaverick pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 9, 2023
@Ruben-VandeVelde @MonadMaverick
feat: port Data.Multiset.Basic change from mathlib3 (#3306)
f9a48d4 
See leanprover-community/mathlib#15161.
xroblot pushed a commit that referenced this pull request Apr 23, 2023
@pechersky @YaelDillies @xroblot
feat(data/list/to_finsupp): computable finsupp from list (#15161)
59ed850 
via `list.nthd`
On the way to computable list-based polynomials



Co-authored-by: Yakov Pechersky <ffxen158@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@pechersky @eric-wieser @mathlib-dependent-issues-bot @jcommelin @prakol16 @BoltonBailey @YaelDillies @Vierkantor @semorrison @leanprover-community-bot-assistant