[Merged by Bors] - chore(set_theory/ordinal/arithmetic): clean up is_normal.sup and related
#15162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
commented
Jul 7, 2022
| @@ -1933,6 +1928,7 @@ begin | |||
| { intros c l IH, | |||
| refine eq_of_forall_ge_iff (λ d, (((opow_is_normal a1).trans | |||
| (add_is_normal b)).limit_le l).trans _), | |||
| dsimp, | |||
There was a problem hiding this comment.
I have no idea why this was needed all of a sudden.
eric-wieser
reviewed
Aug 7, 2022
| @@ -234,7 +234,7 @@ begin | |||
| { let g : ι → ordinal.{u} := λ i, (enum_ord_order_iso hs).symm ⟨_, hf i⟩, | |||
| suffices : enum_ord s (sup.{u u} g) = sup.{u u} f, | |||
| { rw ←this, exact enum_ord_mem hs _ }, | |||
| rw is_normal.sup.{u u u} h g hι, | |||
There was a problem hiding this comment.
I feel like you should be using a resetI instead of this @.
There was a problem hiding this comment.
Adding resetI, before this rw still doesn't work if I don't use @. Not sure why.
eric-wieser
approved these changes
Aug 7, 2022
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
…lated (#15162) We golf various theorems and tweak their arguments. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
is_normal.sup and relatedis_normal.sup and related
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We golf various theorems and tweak their arguments.