[Merged by Bors] - refactor(data/finite/set,data/set/finite): move most contents of one file to another #15166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks great! bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
…file to another (#15166) * move most content of `data.finite.set` to `data.set.finite`; * use `casesI nonempty_fintype _` instead of `letI := fintype.of_finite`; sometimes it lets us avoid `classical.choice`; * merge `set.finite.of_fintype`, `set.finite_of_fintype`, and `set.finite_of_finite` into `set.to_finite`; * rewrite `set.finite_univ_iff` and `finite.of_finite_univ` in terms of `set.finite`; * replace some assumptions `[fintype (plift _)]` with `[finite _]`; * generalize `set.cod_restrict` and some lemmas to allow domain in `Sort*`, use it for `finite.of_injective_finite.range`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data.finite.settodata.set.finite;casesI nonempty_fintype _instead ofletI := fintype.of_finite; sometimes it lets us avoidclassical.choice;set.finite.of_fintype,set.finite_of_fintype, andset.finite_of_finiteintoset.to_finite;set.finite_univ_iffandfinite.of_finite_univin terms ofset.finite;[fintype (plift _)]with[finite _];set.cod_restrictand some lemmas to allow domain inSort*, use it forfinite.of_injective_finite.range.