Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/set/finite): add multiset.finite_to_set #15177

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(data/set/finite): add multiset.finite_to_set #15177

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 8, 2022 •
edited by ocfnash

  • move finset.finite_to_set up;
  • add multiset.finite_to_set, multiset.finite_to_set_to_finset, and list.finite_to_set;
  • use new lemmas here and there.

Open in Gitpod

@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jul 8, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 9, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 9, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Jul 11, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 11, 2022
bors bot pushed a commit that referenced this pull request Jul 11, 2022
@urkud
feat(data/set/finite): add multiset.finite_to_set (#15177)
7f837db 
* move `finset.finite_to_set` up;
* add `multiset.finite_to_set`, `multiset.finite_to_set_to_finset`, and `list.finite_to_set`;
* use new lemmas here and there.
@bors
Copy link

bors bot commented Jul 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/finite): add multiset.finite_to_set [Merged by Bors] - feat(data/set/finite): add multiset.finite_to_set Jul 11, 2022
@bors bors bot closed this Jul 11, 2022
@bors bors bot deleted the YK-finite-finset-multiset branch July 11, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @mathlib-dependent-issues-bot @ocfnash