Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(order/order_iso_nat): remove decidable_pred assumption from subtype.order_iso_of_nat #15190

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(order/order_iso_nat): remove decidable_pred assumption from subtype.order_iso_of_nat #15190

wants to merge 2 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jul 8, 2022 •
edited

This is a noncomputable def anyways, so the assumption wasn't really helping anyone.

Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jul 8, 2022
@ocfnash ocfnash added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 12, 2022
@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Jul 13, 2022
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 13, 2022
bors bot pushed a commit that referenced this pull request Jul 13, 2022
@vihdzp
chore(order/order_iso_nat): remove decidable_pred assumption from `…
5744b50 
…subtype.order_iso_of_nat` (#15190)

This is a `noncomputable def` anyways, so the assumption wasn't really helping anyone.
@bors
Copy link

bors bot commented Jul 13, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/order_iso_nat): remove decidable_pred assumption from subtype.order_iso_of_nat [Merged by Bors] - chore(order/order_iso_nat): remove decidable_pred assumption from subtype.order_iso_of_nat Jul 13, 2022
@bors bors bot closed this Jul 13, 2022
@bors bors bot deleted the oiso_nat_decidable branch July 13, 2022 23:45
joelriou pushed a commit that referenced this pull request Jul 23, 2022
@vihdzp @joelriou
chore(order/order_iso_nat): remove decidable_pred assumption from `…
53eb8b8 
…subtype.order_iso_of_nat` (#15190)

This is a `noncomputable def` anyways, so the assumption wasn't really helping anyone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vihdzp @robertylewis @ocfnash