Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ring_theory/algebra): alg_hom extends ring_hom and use curly brackets #1529

Merged
merged 6 commits into from Oct 11, 2019
Merged

refactor(ring_theory/algebra): alg_hom extends ring_hom and use curly brackets #1529

merged 6 commits into from Oct 11, 2019

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Oct 9, 2019 •
edited

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@ChrisHughes24 ChrisHughes24 added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 9, 2019
@ChrisHughes24 @jcommelin
Update src/ring_theory/algebra.lean
88a1944 
Co-Authored-By: Johan Commelin <johan@commelin.net>
@ChrisHughes24 ChrisHughes24 mentioned this pull request Oct 9, 2019
Closed
7 tasks
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 9, 2019
@jcommelin jcommelin added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 11, 2019
@mergify mergify bot merged commit d5de803 into master Oct 11, 2019
@mergify mergify bot deleted the alg_hom branch October 11, 2019 17:54
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@ChrisHughes24 @anrddh
refactor(ring_theory/algebra): alg_hom extends ring_hom and use curly…
e21b4e7 
… brackets (leanprover-community#1529)

* chore(algebra/ring): use curly brackets for ring_hom where possible

* refactor(ring_theory/algebra): alg_hom extends ring_hom and use curly brackets

* fix build

* Update src/ring_theory/algebra.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* fix build
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisHughes24 @jcommelin @YaelDillies