[Merged by Bors] - refactor(order/boolean_algebra): Get rid of boolean_algebra.core
#15302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
3 tasks
|
LGTM. Thanks! |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…15302) The current setup is problematic for two reasons: * `boolean_algebra.core` is part of the typeclass hierarchy even though it is mathematically the same as `boolean_algebra`. * `boolean_algebra` contains the redundant fields `sup_inf_sdiff` and `inf_inf_sdiff`. The easiest fix is to respectively: * delete `boolean_algebra.core` and use default values in the `boolean_algebra` fields. * not make `boolean_algebra` extend `generalized_boolean_algebra` but instead manually provide the forgetful instance.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
boolean_algebra.coreboolean_algebra.core
joelriou
pushed a commit
that referenced
this pull request
Jul 23, 2022
…15302) The current setup is problematic for two reasons: * `boolean_algebra.core` is part of the typeclass hierarchy even though it is mathematically the same as `boolean_algebra`. * `boolean_algebra` contains the redundant fields `sup_inf_sdiff` and `inf_inf_sdiff`. The easiest fix is to respectively: * delete `boolean_algebra.core` and use default values in the `boolean_algebra` fields. * not make `boolean_algebra` extend `generalized_boolean_algebra` but instead manually provide the forgetful instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup is problematic for two reasons:
boolean_algebra.coreis part of the typeclass hierarchy even though it is mathematically the same asboolean_algebra.boolean_algebracontains the redundant fieldssup_inf_sdiffandinf_inf_sdiff.The easiest fix is to respectively:
boolean_algebra.coreand use default values in theboolean_algebrafields.boolean_algebraextendgeneralized_boolean_algebrabut instead manually provide the forgetful instance.I am doing this now because I want to define Heyting algebras and
boolean_algebra.coremakes it horribly painful to tweak the typeclass hierarchy.