Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/polynomial/unit_trinomial): Irreducibility of X^n-X-1 #15318

Closed
wants to merge 10 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Jul 13, 2022

This PR adds a proves irreducibility of X^n-X-1, superseding #6421.


Open in Gitpod

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Jul 13, 2022
@riccardobrasca
Copy link
Member

There is a reason why this is in data? It contains a nontrivial theorem, I have the impression it is better to have it in ring_theory.polynomial

@tb65536
Copy link
Collaborator Author

tb65536 commented Jul 15, 2022

There is a reason why this is in data? It contains a nontrivial theorem, I have the impression it is better to have it in ring_theory.polynomial

Ah, I'll move this file to ring_theory.polynomial then. I was just putting the polynomial in the same folder as mirror.lean and reverse.lean.

@tb65536 tb65536 added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 15, 2022
@riccardobrasca
Copy link
Member

There is a reason why this is in data? It contains a nontrivial theorem, I have the impression it is better to have it in ring_theory.polynomial

Ah, I'll move this file to ring_theory.polynomial then. I was just putting the polynomial in the same folder as mirror.lean and reverse.lean.

You can keep the definiton and the basic API in data, but the theorems are usually elsewhere.

@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 16, 2022
@tb65536 tb65536 added awaiting-author A reviewer has asked the author a question or requested changes awaiting-review The author would like community review of the PR and removed awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes labels Jul 16, 2022
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

src/ring_theory/polynomial/selmer.lean Outdated Show resolved Hide resolved
src/ring_theory/polynomial/selmer.lean Outdated Show resolved Hide resolved
src/ring_theory/polynomial/selmer.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 16, 2022

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 16, 2022
@tb65536
Copy link
Collaborator Author

tb65536 commented Jul 17, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 17, 2022
This PR adds a proves irreducibility of X^n-X-1, superseding #6421.
@bors
Copy link

bors bot commented Jul 17, 2022

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Jul 17, 2022
This PR adds a proves irreducibility of X^n-X-1, superseding #6421.
@bors
Copy link

bors bot commented Jul 17, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/polynomial/unit_trinomial): Irreducibility of X^n-X-1 [Merged by Bors] - feat(data/polynomial/unit_trinomial): Irreducibility of X^n-X-1 Jul 17, 2022
@bors bors bot closed this Jul 17, 2022
@bors bors bot deleted the selmer13 branch July 17, 2022 17:24
joelriou pushed a commit that referenced this pull request Jul 23, 2022
This PR adds a proves irreducibility of X^n-X-1, superseding #6421.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants