Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/category/Group): The forgetful-units adjunction between Group and Mon. #15330

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(algebra/category/Group): The forgetful-units adjunction between Group and Mon. #15330

wants to merge 2 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jul 14, 2022

Open in Gitpod

@erdOne erdOne added the awaiting-review The author would like community review of the PR label Jul 14, 2022
@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 14, 2022
@erdOne @TwoFX
Apply suggestions from code review
4236eae 
Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 14, 2022
TwoFX
TwoFX approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 15, 2022
bors bot pushed a commit that referenced this pull request Jul 15, 2022
@erdOne
feat(algebra/category/Group): The forgetful-units adjunction between …
ecef686 
…`Group` and `Mon`. (#15330)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/category/Group): The forgetful-units adjunction between Group and Mon. [Merged by Bors] - feat(algebra/category/Group): The forgetful-units adjunction between Group and Mon. Jul 15, 2022
@bors bors bot closed this Jul 15, 2022
@bors bors bot deleted the units_functor branch July 15, 2022 13:03
joelriou pushed a commit that referenced this pull request Jul 23, 2022
@erdOne @joelriou
feat(algebra/category/Group): The forgetful-units adjunction between …
a708ff2 
…`Group` and `Mon`. (#15330)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erdOne @TwoFX @leanprover-community-bot-assistant