feat(measure_theory/integral/circle_transform): Circle transform results pt2 #15356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults needed for the uniform lim of holo result
…esults needed for the uniform lim of holo result
CBirkbeck
changed the title
CBirkbeck
added
awaiting-review
|
Could you split this PR into two, one doing the renaming, and the other one adding the new content? This would make it easier to review. |
sgouezel
added
awaiting-author
|
Ok I changed the name here: #16387 |
CBirkbeck
added
awaiting-review
|
Please add an empty line before the dashed line. Also you have to merge master and fix the merge conflicts (you can do that in github). |
sgouezel
added
awaiting-author
CBirkbeck
added
awaiting-review
alreadydone
reviewed
Oct 29, 2022
Comment on lines
421
to
427
| apply add_nonneg, | ||
| apply (finset.sum_nonneg ), | ||
| intros a b, | ||
| apply absolute_value.nonneg, | ||
| apply add_nonneg, | ||
| apply absolute_value.nonneg, | ||
| apply absolute_value.nonneg, |
There was a problem hiding this comment.
Looks like you didn't enclose subgoals in braces here. And can't you use the positivity tactic?
mcdoll
reviewed
Oct 29, 2022
Comment on lines
177
to
178
| def circle_integral_form [complete_space E] (R : ℝ) (z : ℂ) (f : ℂ → E) : (ℂ → E) := | ||
| λ w, (2 * π * I : ℂ)⁻¹ • (∮ z in C(z, R), (z - w)⁻¹ • f z) |
There was a problem hiding this comment.
Suggested change
| def circle_integral_form [complete_space E] (R : ℝ) (z : ℂ) (f : ℂ → E) : (ℂ → E) := | |
| λ w, (2 * π * I : ℂ)⁻¹ • (∮ z in C(z, R), (z - w)⁻¹ • f z) | |
| def circle_integral_form [complete_space E] (R : ℝ) (z : ℂ) (f : ℂ → E) (w : ℂ) : E := | |
| (2 * π * I : ℂ)⁻¹ • (∮ z in C(z, R), (z - w)⁻¹ • f z) |
mcdoll
added
awaiting-author
semorrison
added
the
too-late
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contains the next set of results needed for #13500 . Note also the change of file name from pt1 since the name
circle_integral_transformis no longer used (so the first 175 lines are not new).