Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/inner_product/calculus): [higher] differentiability to/from euclidean_space #15363

Closed
wants to merge 7 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Jul 14, 2022

This duplicates some of the calculus pi API to euclidean_space. Namely :

  • we duplicate all the variants of differentiable_pi to show that a function to a euclidean space is (higher) differentiable iff all of its components are
  • we introduce euclidean_version.proj, analogous to continuous_linear_map.proj. This allows us to avoid duplicating all the differentiable_apply-like lemmas, because one can just use the API for smoothness of continuous linear maps

Open in Gitpod

@ADedecker ADedecker added the awaiting-review The author would like community review of the PR label Jul 14, 2022
Copy link
Member

@hrmacbeth hrmacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, this could also be done for pi_Lp. No need to do that in this PR, but could you mention it as a TODO? Also please mention your lemmas in the module docstring of analysis/inner_product_space/calculus.

src/analysis/inner_product_space/calculus.lean Outdated Show resolved Hide resolved
src/analysis/inner_product_space/calculus.lean Outdated Show resolved Hide resolved
@hrmacbeth hrmacbeth added awaiting-author A reviewer has asked the author a question or requested changes awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-review The author would like community review of the PR labels Jul 14, 2022
{n : with_top ℕ} :
cont_diff_on 𝕜 n f t ↔ ∀ i, cont_diff_on 𝕜 n (λ x, f x i) t :=
begin
let φ : euclidean_space 𝕜 ι ≃L[𝕜] ι → 𝕜 := (linear_equiv.refl _ _).to_continuous_linear_equiv,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ought to be called pi_Lp.continuous_linear_equiv or pi_Lp.equivL or something; expecially since you used it in all of these lemmas!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the euclidean_space version because rw was giving me a hard time using a general pi_Lp version

@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 15, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 17, 2022
Copy link
Collaborator

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some cosmetic comments, but otherwise LGTM!

bors d+

src/analysis/inner_product_space/calculus.lean Outdated Show resolved Hide resolved
src/analysis/inner_product_space/pi_L2.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 18, 2022

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 18, 2022
@ADedecker
Copy link
Member Author

bors r+

@bors
Copy link

bors bot commented Jul 19, 2022

Canceled.

@urkud
Copy link
Member

urkud commented Jul 19, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 19, 2022
bors bot pushed a commit that referenced this pull request Jul 19, 2022
…from `euclidean_space` (#15363)

This duplicates some of the calculus `pi` API to `euclidean_space`. Namely : 
- we duplicate all the variants of `differentiable_pi` to show that a function to a euclidean space is (higher) differentiable iff all of its components are
- we introduce `euclidean_version.proj`, analogous to `continuous_linear_map.proj`. This allows us to avoid duplicating all the `differentiable_apply`-like lemmas, because one can just use the API for smoothness of continuous linear maps



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Jul 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/inner_product/calculus): [higher] differentiability to/from euclidean_space [Merged by Bors] - feat(analysis/inner_product/calculus): [higher] differentiability to/from euclidean_space Jul 19, 2022
@bors bors bot closed this Jul 19, 2022
@bors bors bot deleted the AD_euclidean_cont_diff branch July 19, 2022 05:43
joelriou pushed a commit that referenced this pull request Jul 23, 2022
…from `euclidean_space` (#15363)

This duplicates some of the calculus `pi` API to `euclidean_space`. Namely : 
- we duplicate all the variants of `differentiable_pi` to show that a function to a euclidean space is (higher) differentiable iff all of its components are
- we introduce `euclidean_version.proj`, analogous to `continuous_linear_map.proj`. This allows us to avoid duplicating all the `differentiable_apply`-like lemmas, because one can just use the API for smoothness of continuous linear maps



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants