[Merged by Bors] - feat(set_theory/game/nim): make the file noncomputable theory
#15367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
the
awaiting-review
ocfnash
added
the
merge-conflict
vihdzp
removed
the
merge-conflict
kmill
reviewed
Jul 23, 2022
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
|
Ok, looks good, thanks! I updated the PR commit message to be more specific -- if you're ok with it, then feel free to merge once CI succeeds. bors d+ |
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
vihdzp
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 23, 2022
Since we're interfacing with ordinals and since `pgame` holds no data, we simplify `nim` and allow it to be noncomputable. We need to give `nim` the `noncomputable!` attribute to avoid a VM compilation bug.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
noncomputable theorynoncomputable theory
joelriou
pushed a commit
that referenced
this pull request
Jul 23, 2022
Since we're interfacing with ordinals and since `pgame` holds no data, we simplify `nim` and allow it to be noncomputable. We need to give `nim` the `noncomputable!` attribute to avoid a VM compilation bug.
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…prover-community#15367) Since we're interfacing with ordinals and since `pgame` holds no data, we simplify `nim` and allow it to be noncomputable. We need to give `nim` the `noncomputable!` attribute to avoid a VM compilation bug.
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
Since we're interfacing with ordinals and since `pgame` holds no data, we simplify `nim` and allow it to be noncomputable. We need to give `nim` the `noncomputable!` attribute to avoid a VM compilation bug.
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
Since we're interfacing with ordinals and since `pgame` holds no data, we simplify `nim` and allow it to be noncomputable. We need to give `nim` the `noncomputable!` attribute to avoid a VM compilation bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're interfacing with ordinals and since
pgameholds no data, we simplifynimand allow it to be noncomputable. We need to givenimthenoncomputable!attribute to avoid a VM compilation bug.