-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(analysis/normed_space/operator_norm): add 2 new versions of op_norm_le_*
#15417
Closed
Closed
[Merged by Bors] - feat(analysis/normed_space/operator_norm): add 2 new versions of op_norm_le_*
#15417
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the file
normed_space.is_R_or_C
precisely exists for the purpose of havingis_R_or_C
-scalars-specific facts about normed spaces. Can you move to there, generalize to scalarsis_R_or_C
, and rewrite to use the lemmanorm_smul_inv_norm
already existing there? Here's a first version, you can probably golf it further :)Same for the
nnnorm
version.(I just noticed that actually, over in that file, there is a lemma
op_norm_bound_of_ball_bound
which looks like it should work for a nondiscrete normed field, but that's a discussion for another day ...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A normed space over an
is_R_or_C
is a normed space over reals, isn't it? Or it needs aletI
? Also, your proof needs anormed_group
while my proof works for asemi_normed_group
.If I generalize it to
is_R_or_C
, then the field should be an explicit argument in the lemma. Am I right?