Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data/int/basic): int.nat_abs_eq_zero #1545

Merged
merged 3 commits into from Oct 13, 2019
Merged

feat(data/int/basic): int.nat_abs_eq_zero #1545

merged 3 commits into from Oct 13, 2019

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Oct 13, 2019 •
edited

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@PatrickMassot PatrickMassot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 13, 2019
@mergify mergify bot merged commit d10fd1e into master Oct 13, 2019
@mergify mergify bot deleted the ChrisHughes24-patch-1 branch October 13, 2019 08:09
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@ChrisHughes24 @anrddh
feat(data/int/basic): int.nat_abs_eq_zero (leanprover-community#1545)
be9637e 
* feat(data/int/basic): int.nat_abs_eq_zero

* Update basic.lean

* Update basic.lean
bors bot pushed a commit that referenced this pull request Jan 14, 2023
@riccardobrasca
chore(algebra/order/ring/canonical): use implicit variables (#18167)
a1b3559 
Make implicitness of variables for `eq_zero_or_eq_zero_of_mul_eq_zero` consistent in `canonically_ordered_comm_semiring` and `no_zero_divisors_`. See the discussion in https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Data.2ESet.2ESemiring

Corresponds to [#1545](leanprover-community/mathlib4#1545).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickMassot PatrickMassot PatrickMassot approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChrisHughes24 @PatrickMassot