Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebraic_geometry/AffineScheme): Affine communication lemma #15487

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(algebraic_geometry/AffineScheme): Affine communication lemma #15487

wants to merge 6 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jul 18, 2022

Open in Gitpod

@erdOne erdOne added this to In progress in Algebraic geometry via automation Jul 18, 2022
@erdOne erdOne added the awaiting-review The author would like community review of the PR label Jul 18, 2022
@erdOne erdOne moved this from In progress to Pending review in Algebraic geometry Jul 18, 2022
jcommelin
jcommelin reviewed Jul 19, 2022
View reviewed changes
src/algebraic_geometry/AffineScheme.lean Outdated Show resolved Hide resolved
src/algebraic_geometry/AffineScheme.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 20, 2022
bors bot pushed a commit that referenced this pull request Jul 20, 2022
@erdOne
feat(algebraic_geometry/AffineScheme): Affine communication lemma (#1…
3cec128 
…5487)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 20, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 20, 2022
@erdOne
feat(algebraic_geometry/AffineScheme): Affine communication lemma (#1…
a165e7b 
…5487)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 20, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 20, 2022
@erdOne
feat(algebraic_geometry/AffineScheme): Affine communication lemma (#1…
fbfeed0 
…5487)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 20, 2022

Build failed:

@erdOne erdOne added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 20, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 21, 2022
@erdOne erdOne added the awaiting-review The author would like community review of the PR label Jul 21, 2022
@riccardobrasca
Copy link
Member

Can you please fix the following error?

Error: /home/lean/actions-runner/_work/mathlib/mathlib/src/algebraic_geometry/AffineScheme.lean:557:4:
invalid simplification lemma 'opens.supr_s' (use command 'set_option trace.simp_lemmas true' for more details)
state:
X : Scheme,
U : opens ↥(X.to_LocallyRingedSpace.to_SheafedSpace.to_PresheafedSpace.carrier),
hU : is_affine_open U,
s : set ↥(X.to_LocallyRingedSpace.to_SheafedSpace.to_PresheafedSpace.presheaf.obj (op U)),
h : ↑U ⊆ ↑⨆ (f : ↥s), X.basic_open ↑f
⊢ (↑⨆ (f : ↥s), X.basic_open ↑f) ≤ ↑U

@erdOne
Copy link
Member Author

erdOne commented Jul 22, 2022

This is already fixed.

@riccardobrasca
Copy link
Member

Sorry!

bors merge

@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Jul 22, 2022
bors bot pushed a commit that referenced this pull request Jul 22, 2022
@erdOne
feat(algebraic_geometry/AffineScheme): Affine communication lemma (#1…
ac9e358 
…5487)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebraic_geometry/AffineScheme): Affine communication lemma [Merged by Bors] - feat(algebraic_geometry/AffineScheme): Affine communication lemma Jul 22, 2022
@bors bors bot closed this Jul 22, 2022
Algebraic geometry automation moved this from Pending review to Done Jul 22, 2022
@bors bors bot deleted the affine_communication branch July 22, 2022 11:08
joelriou pushed a commit that referenced this pull request Jul 23, 2022
@erdOne @joelriou
feat(algebraic_geometry/AffineScheme): Affine communication lemma (#1…
511250e 
…5487)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
@erdOne @bottine
feat(algebraic_geometry/AffineScheme): Affine communication lemma (le…
0f13cbc 
…anprover-community#15487)




Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
Algebraic geometry
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erdOne @riccardobrasca @jcommelin @leanprover-community-bot-assistant