[Merged by Bors] - feat(algebra/module/localized_module): add characteristic predicate for localized_module
#15507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaassoonn
added
the
awaiting-review
eric-wieser
reviewed
Jul 19, 2022
eric-wieser
reviewed
Jul 19, 2022
1 task
| @@ -33,7 +33,6 @@ Given a commutative ring `R`, a multiplicative subset `S ⊆ R` and an `R`-modul | |||
| ## Future work | |||
|
|
|||
| * Redefine `localization` for monoids and rings to coincide with `localized_module`. | |||
There was a problem hiding this comment.
Something that is has to be done is to generalize the API for localized_module to anything that satisfies the characteristic predicate.
There was a problem hiding this comment.
In #15584, Eric is trying to make localized_module and localization definitionally equal
jjaassoonn
added
awaiting-author
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
jjaassoonn
added
awaiting-review
|
This looks fine to me. I'm quite surprised we didn't have this earlier, but we didn't seem to. |
|
Sorry, I forgot about this. Thanks! bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
localized_modulelocalized_module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add characteristic predicate for localised module similar to ring localization and prove that the concrete construction satisfies the characteristic predicate.
Co-authored-by: Andrew Yang @erdOne