Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/symplectic_group): add definition of symplectic group #15513

Closed
wants to merge 24 commits into from

Conversation

mpenciak
Copy link
Collaborator

This PR defines the symplectic group over arbitrary ring (with characteristic not 2)

It also moves the definition of the symplectic.J into the new linear_algebra/symplectic_group file, and adds a lemma from_blocks_neg to data/matrix/block.

Co-authored-by: Moritz Doll moritz.doll@googlemail.com


Open in Gitpod

@mcdoll mcdoll added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 19, 2022
@mpenciak mpenciak added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 19, 2022
@mcdoll mcdoll added the t-algebra Algebra (groups, rings, fields etc) label Jul 25, 2022
src/linear_algebra/symplectic_group.lean Outdated Show resolved Hide resolved
src/linear_algebra/symplectic_group.lean Outdated Show resolved Hide resolved
src/linear_algebra/symplectic_group.lean Outdated Show resolved Hide resolved
src/linear_algebra/symplectic_group.lean Outdated Show resolved Hide resolved
src/linear_algebra/symplectic_group.lean Outdated Show resolved Hide resolved
src/linear_algebra/symplectic_group.lean Outdated Show resolved Hide resolved
src/linear_algebra/symplectic_group.lean Outdated Show resolved Hide resolved
src/linear_algebra/symplectic_group.lean Outdated Show resolved Hide resolved
src/linear_algebra/symplectic_group.lean Outdated Show resolved Hide resolved
src/linear_algebra/symplectic_group.lean Show resolved Hide resolved
@mpenciak mpenciak added the help-wanted The author needs attention to resolve issues label Aug 31, 2022
@mcdoll
Copy link
Member

mcdoll commented Sep 5, 2022

I've golfed a few proofs a bit and I removed the simp-attribute for coe_inv. I think it is not worth brooding about the linter stuff, especially if it effectively stops this PR from being merged. We can add the simp-attribute later if we really want to have it.

@mpenciak mpenciak removed the help-wanted The author needs attention to resolve issues label Sep 5, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 16, 2022
bors bot pushed a commit that referenced this pull request Sep 16, 2022
…roup (#15513)

This PR defines the symplectic group over arbitrary ring (with characteristic not 2)

It also moves the definition of the `symplectic.J` into the new `linear_algebra/symplectic_group` file, and adds a lemma `from_blocks_neg` to `data/matrix/block`. 

Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>



Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
@bors
Copy link

bors bot commented Sep 16, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 16, 2022
…roup (#15513)

This PR defines the symplectic group over arbitrary ring (with characteristic not 2)

It also moves the definition of the `symplectic.J` into the new `linear_algebra/symplectic_group` file, and adds a lemma `from_blocks_neg` to `data/matrix/block`. 

Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>



Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
@bors
Copy link

bors bot commented Sep 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/symplectic_group): add definition of symplectic group [Merged by Bors] - feat(linear_algebra/symplectic_group): add definition of symplectic group Sep 16, 2022
@bors bors bot closed this Sep 16, 2022
@bors bors bot deleted the mp/symplectic_group branch September 16, 2022 12:10
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
…roup (#15513)

This PR defines the symplectic group over arbitrary ring (with characteristic not 2)

It also moves the definition of the `symplectic.J` into the new `linear_algebra/symplectic_group` file, and adds a lemma `from_blocks_neg` to `data/matrix/block`. 

Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>



Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants