[Merged by Bors] - refactor(analysis/special_functions/pow): assume n ≠ 0 instead of 0 < n
#15553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
urkud
commented
Jul 20, 2022
urkud
commented
urkud
added
awaiting-review
|
Do we have any sort of convention on I imagine we should use ≠ in hypotheses, since it's easier to go from < to ≠ than the other way around? |
|
Yes, we should use something like example (m n : nat) (hm : m ≠ 0) (hn : n ≠ 0) : 0 < m * n := sorry |
vihdzp
removed
the
awaiting-CI
|
bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
n ≠ 0 instead of 0 < nn ≠ 0 instead of 0 < n
joelriou
pushed a commit
that referenced
this pull request
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.