Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(group_theory/monoid_localization): flip the direction of multiplication #15584
[Merged by Bors] - refactor(group_theory/monoid_localization): flip the direction of multiplication #15584
Changes from 28 commits
199e331
944c914
1dbc914
23e1d18
b0aafa7
795ee1f
468eecf
e8b8d91
c851e49
e390c66
dfcc120
b0bb1f0
e1ed73f
83defae
90b0482
d4e679e
e303875
9731245
82739a7
965e3ae
1501b1b
ed136af
3b183ef
02437f3
c8e9030
f89f40f
071a512
f0e064b
aaeacfc
10e07c6
7bdadc8
a015bca
a58a384
80cfeb8
62233a8
05c054c
89789d7
80eb744
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjaassoonn, do you remember why you changed this in dfcc120?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested the original version. Without flipping p and q, the
H q.2 q’.2
on line 143 would not compile.