[Merged by Bors] - feat(topology/metric_space/isometry): use namespace, add lemmas #15591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `namespace isometry`. * Add lemmas like `isometry.preimage_ball`.
sgouezel
reviewed
Jul 22, 2022
| @@ -30,130 +30,137 @@ between pseudoemetric spaces, or equivalently the distance between pseudometric | |||
| def isometry [pseudo_emetric_space α] [pseudo_emetric_space β] (f : α → β) : Prop := | |||
| ∀x1 x2 : α, edist (f x1) (f x2) = edist x1 x2 | |||
|
|
|||
| /-- On pseudometric spaces, a map is an isometry if and only if it preserves nonnegative | |||
| distances. -/ | |||
| lemma isometry_emetric_iff_nndist [pseudo_metric_space α] [pseudo_metric_space β] {f : α → β} : | |||
There was a problem hiding this comment.
The name looks uselessly verbose to me, especially since there is absolutely no emetric in sight. What about isometry_iff_nndist_eq (and the next one could be renamed isometry_iff_dist_eq).
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
…unity/mathlib into YK-isometry-lemmas
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
* Use `namespace isometry`. * Add lemmas like `isometry.preimage_ball`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
joelriou
pushed a commit
that referenced
this pull request
Jul 23, 2022
* Use `namespace isometry`. * Add lemmas like `isometry.preimage_ball`.
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…prover-community#15591) * Use `namespace isometry`. * Add lemmas like `isometry.preimage_ball`.
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
* Use `namespace isometry`. * Add lemmas like `isometry.preimage_ball`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namespace isometry.isometry.preimage_ball.