Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - move(order/{boolean_algebra → basic}): move has_compl and trivial instances #15602

Closed
wants to merge 3 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jul 21, 2022

We move the trivial pi.has_sdiff, pi.has_compl, and Prop.has_compl instances to order/basic.lean. The main effect of this is that rᶜ for the complement of a relation is now available basically anywhere.


Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jul 21, 2022
src/order/basic.lean Outdated Show resolved Hide resolved
src/order/basic.lean Outdated Show resolved Hide resolved
src/order/basic.lean Outdated Show resolved Hide resolved
src/order/basic.lean Outdated Show resolved Hide resolved
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let another maintainer confirm

@bryangingechen bryangingechen changed the title move(order/{boolean_algebra → basic}): move trivial instances move(order/{boolean_algebra → basic}): move has_compl and trivial instances Jul 22, 2022
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 22, 2022
bors bot pushed a commit that referenced this pull request Jul 22, 2022
…nstances (#15602)

We move the trivial `pi.has_sdiff`, `pi.has_compl`, and `Prop.has_compl` instances to `order/basic.lean`. The main effect of this is that `rᶜ` for the complement of a relation is now available basically anywhere.
@bors
Copy link

bors bot commented Jul 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title move(order/{boolean_algebra → basic}): move has_compl and trivial instances [Merged by Bors] - move(order/{boolean_algebra → basic}): move has_compl and trivial instances Jul 22, 2022
@bors bors bot closed this Jul 22, 2022
@bors bors bot deleted the pi_compl_move branch July 22, 2022 21:09
joelriou pushed a commit that referenced this pull request Jul 23, 2022
…nstances (#15602)

We move the trivial `pi.has_sdiff`, `pi.has_compl`, and `Prop.has_compl` instances to `order/basic.lean`. The main effect of this is that `rᶜ` for the complement of a relation is now available basically anywhere.
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
…nstances (leanprover-community#15602)

We move the trivial `pi.has_sdiff`, `pi.has_compl`, and `Prop.has_compl` instances to `order/basic.lean`. The main effect of this is that `rᶜ` for the complement of a relation is now available basically anywhere.
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
…nstances (#15602)

We move the trivial `pi.has_sdiff`, `pi.has_compl`, and `Prop.has_compl` instances to `order/basic.lean`. The main effect of this is that `rᶜ` for the complement of a relation is now available basically anywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants