-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - move(order/{boolean_algebra → basic}): move has_compl
and trivial instances
#15602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Jul 22, 2022
eric-wieser
reviewed
Jul 22, 2022
eric-wieser
reviewed
Jul 22, 2022
eric-wieser
reviewed
Jul 22, 2022
eric-wieser
reviewed
Jul 22, 2022
eric-wieser
reviewed
Jul 22, 2022
eric-wieser
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will let another maintainer confirm
has_compl
and trivial instances
bryangingechen
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+
bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
…nstances (#15602) We move the trivial `pi.has_sdiff`, `pi.has_compl`, and `Prop.has_compl` instances to `order/basic.lean`. The main effect of this is that `rᶜ` for the complement of a relation is now available basically anywhere.
Pull request successfully merged into master. Build succeeded: |
has_compl
and trivial instanceshas_compl
and trivial instances
joelriou
pushed a commit
that referenced
this pull request
Jul 23, 2022
…nstances (#15602) We move the trivial `pi.has_sdiff`, `pi.has_compl`, and `Prop.has_compl` instances to `order/basic.lean`. The main effect of this is that `rᶜ` for the complement of a relation is now available basically anywhere.
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…nstances (leanprover-community#15602) We move the trivial `pi.has_sdiff`, `pi.has_compl`, and `Prop.has_compl` instances to `order/basic.lean`. The main effect of this is that `rᶜ` for the complement of a relation is now available basically anywhere.
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
…nstances (#15602) We move the trivial `pi.has_sdiff`, `pi.has_compl`, and `Prop.has_compl` instances to `order/basic.lean`. The main effect of this is that `rᶜ` for the complement of a relation is now available basically anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We move the trivial
pi.has_sdiff
,pi.has_compl
, andProp.has_compl
instances toorder/basic.lean
. The main effect of this is thatrᶜ
for the complement of a relation is now available basically anywhere.