[Merged by Bors] - doc(field_theory/splitting_field): update code example to reflect changes to diamond issues #15620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
…nges to diamond issues
eric-wieser
force-pushed
the
eric-wieser/tidy-splitting_field-docstring
branch
from
c21a37f
to
243c99c
Compare
|
Let me see if I can't just fix this before we update the docs to say it can't be fixed... |
|
I wouldn't say the docs says "this can't be fixed", they just more clearly say "this is broken" and remove the now-invalid excuse! |
|
@Vierkantor could you please take another look? You've been working on the |
|
Alright, let's merge this for now because the diamond is rather evil... bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
…nges to diamond issues (#15620) We now have infrastructure in place to avoid diamonds in nat/int/rat algebras, so we can't appeal to a lack of it when explaining diamond issues.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…nges to diamond issues (leanprover-community#15620) We now have infrastructure in place to avoid diamonds in nat/int/rat algebras, so we can't appeal to a lack of it when explaining diamond issues.
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
…nges to diamond issues (#15620) We now have infrastructure in place to avoid diamonds in nat/int/rat algebras, so we can't appeal to a lack of it when explaining diamond issues.
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
…nges to diamond issues (#15620) We now have infrastructure in place to avoid diamonds in nat/int/rat algebras, so we can't appeal to a lack of it when explaining diamond issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have infrastructure in place to avoid diamonds in nat/int/rat algebras, so we can't appeal to a lack of it when explaining diamond issues.