Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(field_theory/finite): Chevalley–Warning #1564
[Merged by Bors] - feat(field_theory/finite): Chevalley–Warning #1564
Changes from 1 commit
792cde8
74ff642
804912a
867eb00
68bef93
3cfe90e
0f0b1b1
6603845
12a306c
b900b0b
60da8ea
95b3382
4f7e38a
8d5f72a
d2944ee
ca43045
7a1afbd
a9b7dcf
1ed8801
be84c3d
2450959
00c1756
4e1c410
49de949
8e8c871
57dbc1a
26c6a07
a242ea1
88a5f98
3822558
fa3dbd6
9b5d7b2
13821c0
8b2cf7d
d40e72f
2fc68f8
60f0110
57e7847
f807947
87c91cd
910d679
c78d943
ee590e2
5da96f0
b7c3111
1d1db80
b84525f
dceef1f
3797267
53c170e
8bf853f
c81d602
9734cc2
4d24680
757475b
234d57e
e3792ec
d34c69f
0816f6f
12320ab
dbcda17
15261ef
e49efc1
b46d997
dbd5ce3
68e8f6a
ca76a9b
7399607
b394545
3073980
312fb08
e23560b
6b47d22
7946a32
ff4a3fe
b336013
8a79bb2
a423db5
02ec503
3e0d012
5fefb9c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could write
and avoid "fake tactic mode".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mwah... there is so much tactic mode in this proof that I don't care about a little bit of fake tactic mode as well. (I know that
calc
is a fake tactic. But all thebegin ... end
blocks aren't)Anyway, I can fix it if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed after other suggested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a TODO