[Merged by Bors] - refactor(order/succ_pred/limit): redefine successor/predecessor limits #15655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
the
awaiting-review
YaelDillies
reviewed
Aug 3, 2022
|
If |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Please leave them in the current file for now. That will make for a much more informative diff. You can always rename the file later. |
|
I'll leave these results in the file for now. Do note that the file will either be deleted or substantially changed if the planned |
YaelDillies
approved these changes
Sep 5, 2022
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
#15655) I realized too late that there is a much simpler definition for a successor/predecessor limit (defined in #15001) in terms of the covering relation. We redefine these predicates and port over the existing API. Note that this new definition is only equivalent to the old one in partial orders. The API has remained exactly the same with two caveats: - A few theorems need their assumptions strengthened from preorders to partial orders. - Since `is_succ_limit` is now defined outside of the `order` namespace, all its theorems are moved outside of it too. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized too late that there is a much simpler definition for a successor/predecessor limit (defined in #15001) in terms of the covering relation. We redefine these predicates and port over the existing API. Note that this new definition is only equivalent to the old one in partial orders.
The API has remained exactly the same with two caveats:
is_succ_limitis now defined outside of theordernamespace, all its theorems are moved outside of it too.