Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/normed/field/basic): define densely_normed_field give instances for ℚ, ℝ, ℂ and is_R_or_C #15657

Closed
wants to merge 17 commits into from

Conversation

j-loreaux
Copy link
Collaborator

This adds a new type class extending normed_field which is named densely_normed_field per this Zulip discussion. The name comes from the fact that the (nn)norm has dense range in ℝ≥0. This type class is strictly stronger than nontrivially_normed_field, with padic being a field which is nontrivially normed but not densely normed.

The instances of nontrivially_normed_field for each of ℚ, ℝ, ℂ have all been migrated to densely_normed_field instead. Moreover, is_R_or_C now extends densely_normed_field; this is natural because even if it only extends nontrivially_normed_field, it would still be possible to prove that the norm has dense range in ℝ≥0.


Open in Gitpod

@j-loreaux j-loreaux added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR labels Jul 24, 2022
@urkud urkud added the t-analysis Analysis (normed *, calculus) label Jul 24, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 4, 2022
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

src/analysis/normed/field/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Aug 9, 2022

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 9, 2022
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@j-loreaux
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Aug 9, 2022
… instances for ℚ, ℝ, ℂ and `is_R_or_C` (#15657)

This adds a new type class extending `normed_field` which is named `densely_normed_field` per this [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/hypotheses.20for.20a.20field.20property/near/290408091). The name comes from the fact that the (nn)norm has dense range in ℝ≥0. This type class is strictly stronger than `nontrivially_normed_field`, with `padic` being a field which is nontrivially normed but not densely normed. 

The instances of `nontrivially_normed_field` for each of ℚ, ℝ, ℂ have all been migrated to `densely_normed_field` instead. Moreover, `is_R_or_C` now extends `densely_normed_field`; this is natural because even if it only extends `nontrivially_normed_field`, it would still be possible to prove that the norm has dense range in ℝ≥0.
@bors
Copy link

bors bot commented Aug 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed/field/basic): define densely_normed_field give instances for ℚ, ℝ, ℂ and is_R_or_C [Merged by Bors] - feat(analysis/normed/field/basic): define densely_normed_field give instances for ℚ, ℝ, ℂ and is_R_or_C Aug 9, 2022
@bors bors bot closed this Aug 9, 2022
@bors bors bot deleted the j-loreaux/densely-normed-field branch August 9, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants