Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(field_theory/splitting_field): If an intermediate field contains all of the roots, then the polynomial splits #15658

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(field_theory/splitting_field): If an intermediate field contains all of the roots, then the polynomial splits #15658

wants to merge 2 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Jul 24, 2022

This lemma came up when proving that if p splits in L/K, then p.is_splitting_field K (adjoin K (p.root_set L))

Open in Gitpod

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Jul 24, 2022
@urkud urkud added the t-algebra Algebra (groups, rings, fields etc) label Jul 24, 2022
@tb65536 tb65536 added awaiting-author A reviewer has asked the author a question or requested changes awaiting-review The author would like community review of the PR and removed awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes labels Jul 28, 2022
alreadydone
alreadydone approved these changes Jul 28, 2022
View reviewed changes
src/field_theory/splitting_field.lean Outdated Show resolved Hide resolved
@tb65536 @alreadydone
Update src/field_theory/splitting_field.lean
0f6f1d3 
Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
@tb65536 tb65536 mentioned this pull request Aug 1, 2022
Closed
4 tasks
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 4, 2022
bors bot pushed a commit that referenced this pull request Aug 4, 2022
@tb65536
feat(field_theory/splitting_field): If an intermediate field contains…
20f68fc 
… all of the roots, then the polynomial splits (#15658)

This lemma came up when proving that if `p` splits in `L/K`, then `p.is_splitting_field K (adjoin K (p.root_set L))`



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Aug 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/splitting_field): If an intermediate field contains all of the roots, then the polynomial splits [Merged by Bors] - feat(field_theory/splitting_field): If an intermediate field contains all of the roots, then the polynomial splits Aug 4, 2022
@bors bors bot closed this Aug 4, 2022
@bors bors bot deleted the intermediate_field.splits_of_splits branch August 4, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tb65536 @riccardobrasca @alreadydone @urkud