[Merged by Bors] - refactor(linear_algebra, analysis/inner_product_space): use ⊤ ≤ instead of = ⊤ in bases constructors
#15697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADedecker
added
the
awaiting-review
hrmacbeth
approved these changes
Jul 27, 2022
Vierkantor
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
LGTM. I'll bors it if the Zulip thread is still positive after it's been up for a couple of hours.
|
The consensus is positive, so: bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
…tead of `= ⊤` in bases constructors (#15697) All the existing proof just need a `.ge` to be fixed, and this allows to remove a lot of `rw [eq_top_iff]`, and it sticks with the convention of having weakest forms in assumptions and stronger forms in conclusion. Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60.E2.8A.A4.20.E2.89.A4.20span.60.20in.20basis.20constructors
|
Build failed: |
|
Could you please merge master and fix the issues? bors d+ |
|
✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
…tead of `= ⊤` in bases constructors (#15697) All the existing proof just need a `.ge` to be fixed, and this allows to remove a lot of `rw [eq_top_iff]`, and it sticks with the convention of having weakest forms in assumptions and stronger forms in conclusion. Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60.E2.8A.A4.20.E2.89.A4.20span.60.20in.20basis.20constructors
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
⊤ ≤ instead of = ⊤ in bases constructors⊤ ≤ instead of = ⊤ in bases constructors
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…tead of `= ⊤` in bases constructors (leanprover-community#15697) All the existing proof just need a `.ge` to be fixed, and this allows to remove a lot of `rw [eq_top_iff]`, and it sticks with the convention of having weakest forms in assumptions and stronger forms in conclusion. Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60.E2.8A.A4.20.E2.89.A4.20span.60.20in.20basis.20constructors
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
…tead of `= ⊤` in bases constructors (#15697) All the existing proof just need a `.ge` to be fixed, and this allows to remove a lot of `rw [eq_top_iff]`, and it sticks with the convention of having weakest forms in assumptions and stronger forms in conclusion. Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60.E2.8A.A4.20.E2.89.A4.20span.60.20in.20basis.20constructors
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
…tead of `= ⊤` in bases constructors (#15697) All the existing proof just need a `.ge` to be fixed, and this allows to remove a lot of `rw [eq_top_iff]`, and it sticks with the convention of having weakest forms in assumptions and stronger forms in conclusion. Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60.E2.8A.A4.20.E2.89.A4.20span.60.20in.20basis.20constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the existing proof just need a
.geto be fixed, and this allows to remove a lot ofrw [eq_top_iff], and it sticks with the convention of having weakest forms in assumptions and stronger forms in conclusion.Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60.E2.8A.A4.20.E2.89.A4.20span.60.20in.20basis.20constructors