Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/subset_properties): locally_compact_space instance for Π types #15707

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(topology/subset_properties): locally_compact_space instance for Π types #15707

wants to merge 5 commits into from

Conversation

ralvrz
Copy link
Collaborator

@ralvrz ralvrz commented Jul 27, 2022 •
edited
Loading

This PR adds

  • locally_compact_space.pi mirroring locally_compact_space.prod and
  • locally_compact_space.pi_finite for finite products

Proof by: @alreadydone

Open in Gitpod

@alreadydone
Copy link
Collaborator

alreadydone commented Jul 27, 2022 •
edited
Loading

I just pushed a version without the compact assumption in the finite case, which is a generalization of locally_compact_space.prod. In general it suffices that all but finitely many of the spaces are compact, but that's not straightforward to state and use.

@ralvrz ralvrz added the awaiting-review The author would like community review of the PR label Jul 27, 2022
ocfnash
ocfnash approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I think it is worth turning the PR comment about cofinitely-many compact spaces "In general it suffices that all but finitely many of the spaces are compact, but that's not straightforward to state and use." into a code comment.

Please also apply the other suggestions and then feel free to merge.

bors d+

src/topology/subset_properties.lean Outdated Show resolved Hide resolved
src/topology/subset_properties.lean Show resolved Hide resolved
src/topology/subset_properties.lean Show resolved Hide resolved
src/topology/subset_properties.lean Outdated Show resolved Hide resolved
src/topology/subset_properties.lean Outdated Show resolved Hide resolved
src/topology/subset_properties.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 27, 2022

✌️ ralvrz can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 27, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Jul 27, 2022

bors d=alreadydone

@bors
Copy link

bors bot commented Jul 27, 2022

✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

ralvrz and others added 3 commits July 27, 2022 09:32
@ralvrz
Copy link
Collaborator Author

ralvrz commented Jul 27, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 27, 2022
@ralvrz @alreadydone
feat(topology/subset_properties): locally_compact_space instance fo…
cd7b23d 
…r `Π` types (#15707)

This PR adds 
- `locally_compact_space.pi` mirroring `locally_compact_space.prod` and
- `locally_compact_space.pi_finite` for finite products

Proof by: @alreadydone 



Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
@bors
Copy link

bors bot commented Jul 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/subset_properties): locally_compact_space instance for Π types [Merged by Bors] - feat(topology/subset_properties): locally_compact_space instance for Π types Jul 28, 2022
@bors bors bot closed this Jul 28, 2022
@bors bors bot deleted the prod_locally_compact branch July 28, 2022 00:01
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
@ralvrz @alreadydone @bottine
feat(topology/subset_properties): locally_compact_space instance fo…
025c700 
…r `Π` types (leanprover-community#15707)

This PR adds 
- `locally_compact_space.pi` mirroring `locally_compact_space.prod` and
- `locally_compact_space.pi_finite` for finite products

Proof by: @alreadydone 



Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
ralvrz added a commit that referenced this pull request Aug 1, 2022
@ralvrz @alreadydone
feat(topology/subset_properties): locally_compact_space instance fo…
10012c1 
…r `Π` types (#15707)

This PR adds
- `locally_compact_space.pi` mirroring `locally_compact_space.prod` and
- `locally_compact_space.pi_finite` for finite products

Proof by: @alreadydone

Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
@ralvrz @alreadydone @robertylewis
feat(topology/subset_properties): locally_compact_space instance fo…
868d1cf 
…r `Π` types (#15707)

This PR adds 
- `locally_compact_space.pi` mirroring `locally_compact_space.prod` and
- `locally_compact_space.pi_finite` for finite products

Proof by: @alreadydone 



Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
khwilson pushed a commit that referenced this pull request Aug 2, 2022
@ralvrz @alreadydone @khwilson
feat(topology/subset_properties): locally_compact_space instance fo…
585a9ff 
…r `Π` types (#15707)

This PR adds 
- `locally_compact_space.pi` mirroring `locally_compact_space.prod` and
- `locally_compact_space.pi_finite` for finite products

Proof by: @alreadydone 



Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone left review comments

@ocfnash ocfnash ocfnash approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ralvrz @alreadydone @ocfnash @leanprover-community-bot-assistant