[Merged by Bors] - chore(field_theory/splitting_field): remove unneeded parameter #15716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definition of `splitting_field_aux` relied on a parameter `hfn : n = f.nat_degree` that was never actually used in the construction or its instances, only in the `splits` theorem. So we might as well delete it. This PR prepares for a redefinition of all instances on `splitting_field_aux` to fix instance diamonds, see the `splitting_field-diamond` branch for progress.
Vierkantor
added
easy
eric-wieser
reviewed
Jul 27, 2022
|
bors d+ This all looks reasonable to me. I guess one thing to consider is whether it should be called |
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
Vierkantor
commented
Jul 27, 2022
github-actions
bot
removed
the
awaiting-CI
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
The definition of `splitting_field_aux` relied on a parameter `hfn : n = f.nat_degree` that was never actually used in the construction or its instances, only in the `splits` theorem. So we might as well delete it. This PR prepares for a redefinition of all instances on `splitting_field_aux` to fix instance diamonds, see the `splitting_field-diamond` branch for progress. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
The definition of `splitting_field_aux` relied on a parameter `hfn : n = f.nat_degree` that was never actually used in the construction or its instances, only in the `splits` theorem. So we might as well delete it. This PR prepares for a redefinition of all instances on `splitting_field_aux` to fix instance diamonds, see the `splitting_field-diamond` branch for progress. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…rover-community#15716) The definition of `splitting_field_aux` relied on a parameter `hfn : n = f.nat_degree` that was never actually used in the construction or its instances, only in the `splits` theorem. So we might as well delete it. This PR prepares for a redefinition of all instances on `splitting_field_aux` to fix instance diamonds, see the `splitting_field-diamond` branch for progress. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
The definition of `splitting_field_aux` relied on a parameter `hfn : n = f.nat_degree` that was never actually used in the construction or its instances, only in the `splits` theorem. So we might as well delete it. This PR prepares for a redefinition of all instances on `splitting_field_aux` to fix instance diamonds, see the `splitting_field-diamond` branch for progress. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
The definition of `splitting_field_aux` relied on a parameter `hfn : n = f.nat_degree` that was never actually used in the construction or its instances, only in the `splits` theorem. So we might as well delete it. This PR prepares for a redefinition of all instances on `splitting_field_aux` to fix instance diamonds, see the `splitting_field-diamond` branch for progress. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of
splitting_field_auxrelied on a parameterhfn : n = f.nat_degreethat was never actually used in the construction or its instances, only in thesplitstheorem. So we might as well delete it.This PR prepares for a redefinition of all instances on
splitting_field_auxto fix instance diamonds, see thesplitting_field-diamondbranch for progress.