Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(geometry/euclidean/oriented_angle): relation to unoriented angles #15722

Closed
wants to merge 2 commits into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Jul 27, 2022

Add some versions of the result that an oriented angle is plus or
minus the unoriented angle between the same two vectors.

There will be a lot more lemmas to add subsequently in this area
(including, in particular, lemmas about when two angles have the same
or different signs, that are needed to go from equality of unoriented
angles to equality of oriented angles). This just provides the
starting point for adding such results.


Open in Gitpod

Add some versions of the result that an oriented angle is plus or
minus the unoriented angle between the same two vectors.

There will be a lot more lemmas to add subsequently in this area
(including, in particular, lemmas about when two angles have the same
or different signs, that are needed to go from equality of unoriented
angles to equality of oriented angles).  This just provides the
starting point for adding such results.
@jsm28 jsm28 added the awaiting-review The author would like community review of the PR label Jul 27, 2022
Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional comment but otherwise looks great :-)

bors d+

src/geometry/euclidean/oriented_angle.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Aug 1, 2022

✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 1, 2022
@jsm28
Copy link
Collaborator Author

jsm28 commented Aug 1, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 1, 2022
#15722)

Add some versions of the result that an oriented angle is plus or
minus the unoriented angle between the same two vectors.

There will be a lot more lemmas to add subsequently in this area
(including, in particular, lemmas about when two angles have the same
or different signs, that are needed to go from equality of unoriented
angles to equality of oriented angles).  This just provides the
starting point for adding such results.
@bors
Copy link

bors bot commented Aug 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(geometry/euclidean/oriented_angle): relation to unoriented angles [Merged by Bors] - feat(geometry/euclidean/oriented_angle): relation to unoriented angles Aug 1, 2022
@bors bors bot closed this Aug 1, 2022
@bors bors bot deleted the jsm28/oangle_angle branch August 1, 2022 13:04
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
#15722)

Add some versions of the result that an oriented angle is plus or
minus the unoriented angle between the same two vectors.

There will be a lot more lemmas to add subsequently in this area
(including, in particular, lemmas about when two angles have the same
or different signs, that are needed to go from equality of unoriented
angles to equality of oriented angles).  This just provides the
starting point for adding such results.
khwilson pushed a commit that referenced this pull request Aug 2, 2022
#15722)

Add some versions of the result that an oriented angle is plus or
minus the unoriented angle between the same two vectors.

There will be a lot more lemmas to add subsequently in this area
(including, in particular, lemmas about when two angles have the same
or different signs, that are needed to go from equality of unoriented
angles to equality of oriented angles).  This just provides the
starting point for adding such results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants