Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(field_theory/splitting_field): Add image_root_set #15743

Closed
wants to merge 6 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Jul 28, 2022

This PR adds a short lemma image_root_set and uses it to prove that is_splitting_field is preserved by algebra isomorphisms.


Open in Gitpod

@tb65536 tb65536 added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Jul 28, 2022
@tb65536 tb65536 changed the title feat(field_theory/splitting_field): Add map_root_set feat(field_theory/splitting_field): Add image_root_set Jul 29, 2022
@alreadydone
Copy link
Collaborator

alreadydone commented Aug 1, 2022

Can you add this lemma to this PR? Its proof needs this lemma. Should be right next to polynomial.is_splitting_field.alg_equiv, and we could even make an iff version.

lemma polynomial.is_splitting_field.of_alg_equiv (f : L ≃ₐ[K] L') (p : K[X])
  [is_splitting_field K L' p] : is_splitting_field K L p :=
begin
  have : splits (algebra_map K L) p,
  { rw ← f.symm.to_alg_hom.comp_algebra_map,
    exact splits_comp_of_splits _ _ (is_splitting_field.splits L' p) },
  refine ⟨this, subalgebra.map_injective f.to_alg_hom f.injective _⟩,
  rw [algebra.map_top, (algebra.range_top_iff_surjective f.to_alg_hom).2 f.surjective],
  erw [← algebra.adjoin_image, image_root_set this],
  exact is_splitting_field.adjoin_roots L' p,
end

@tb65536
Copy link
Collaborator Author

tb65536 commented Aug 2, 2022

@alreadydone I've added that lemma, although I also extracted a useful sublemma that also came up in #15795

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 8, 2022
bors bot pushed a commit that referenced this pull request Aug 8, 2022
This PR adds a short lemma `image_root_set` and uses it to prove that `is_splitting_field` is preserved by algebra isomorphisms.



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Aug 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/splitting_field): Add image_root_set [Merged by Bors] - feat(field_theory/splitting_field): Add image_root_set Aug 9, 2022
@bors bors bot closed this Aug 9, 2022
@bors bors bot deleted the map_root_set branch August 9, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants