-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(field_theory/splitting_field): Add image_root_set
#15743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tb65536
added
awaiting-review
The author would like community review of the PR
t-algebra
Algebra (groups, rings, fields etc)
labels
Jul 28, 2022
vihdzp
reviewed
Jul 29, 2022
tb65536
commented
Jul 29, 2022
tb65536
changed the title
feat(field_theory/splitting_field): Add
feat(field_theory/splitting_field): Add Jul 29, 2022
map_root_set
image_root_set
4 tasks
Can you add this lemma to this PR? Its proof needs this lemma. Should be right next to polynomial.is_splitting_field.alg_equiv, and we could even make an iff version.
|
…y/mathlib into map_root_set merge
@alreadydone I've added that lemma, although I also extracted a useful sublemma that also came up in #15795 |
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Aug 8, 2022
bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2022
This PR adds a short lemma `image_root_set` and uses it to prove that `is_splitting_field` is preserved by algebra isomorphisms. Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(field_theory/splitting_field): Add
[Merged by Bors] - feat(field_theory/splitting_field): Add Aug 9, 2022
image_root_set
image_root_set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
t-algebra
Algebra (groups, rings, fields etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a short lemma
image_root_set
and uses it to prove thatis_splitting_field
is preserved by algebra isomorphisms.