Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/adjoin_root): a bit of missing API for maps between certain quotients of adjoin_root f #15757

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(ring_theory/adjoin_root): a bit of missing API for maps between certain quotients of adjoin_root f #15757

wants to merge 5 commits into from

Conversation

Paul-Lez
Copy link
Collaborator

@Paul-Lez Paul-Lez commented Jul 29, 2022 •
edited

A few lemmas needed for #15000.

Co-authored-by: Anne Baanen.

Open in Gitpod

@Paul-Lez Paul-Lez changed the title feat(ring_theory/adjoin_root): a bit of missing API for maps between quotients of adjoin_root f feat(ring_theory/adjoin_root): a bit of missing API for maps between certain quotients of adjoin_root f Jul 29, 2022
@Paul-Lez Paul-Lez added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 29, 2022
@hrmacbeth hrmacbeth added the t-algebra Algebra (groups, rings, fields etc) label Jul 31, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 10, 2022
jcommelin
jcommelin approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 11, 2022
bors bot pushed a commit that referenced this pull request Aug 11, 2022
@Paul-Lez
feat(ring_theory/adjoin_root): a bit of missing API for maps between …
802513c 
…certain quotients of `adjoin_root f` (#15757)

A few lemmas needed for #15000.

Co-authored-by: Anne Baanen.
@bors
Copy link

bors bot commented Aug 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/adjoin_root): a bit of missing API for maps between certain quotients of adjoin_root f [Merged by Bors] - feat(ring_theory/adjoin_root): a bit of missing API for maps between certain quotients of adjoin_root f Aug 11, 2022
@bors bors bot closed this Aug 11, 2022
@bors bors bot deleted the adjoin_root_commits branch August 11, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Paul-Lez @jcommelin @hrmacbeth @leanprover-community-bot-assistant