[Merged by Bors] - fix(data/polynomial/basic): remove monomial_fun to remove diamonds
#15778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericrbg
added
awaiting-review
eric-wieser
changed the title
monomial_fun semirreduciblemonomial_fun semirreducible
eric-wieser
reviewed
Jul 31, 2022
ericrbg
changed the title
monomial_fun semirreduciblemonomial_fun to remove diamonds
eric-wieser
approved these changes
Jul 31, 2022
|
|
1 task
eric-wieser
reviewed
Jul 31, 2022
eric-wieser
reviewed
Jul 31, 2022
github-actions
bot
removed
the
awaiting-CI
Vierkantor
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Already when monomial_fun was defined there was a conversation on the dangers of having these irreducible definitions. Since there seem to be no weird slowdowns by bad unfolds, this change seems like a strict improvement. So:
bors r+
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
…15778) This was previously irreducible to prevent any `finsupp/add_monoid_algebra` leakage, but it causes a non-defeq diamond in instances. Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
1 task
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
monomial_fun to remove diamondsmonomial_fun to remove diamonds
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
…15778) This was previously irreducible to prevent any `finsupp/add_monoid_algebra` leakage, but it causes a non-defeq diamond in instances. Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
…15778) This was previously irreducible to prevent any `finsupp/add_monoid_algebra` leakage, but it causes a non-defeq diamond in instances. Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously irreducible to prevent any
finsupp/add_monoid_algebraleakage, but it causes a non-defeq diamond in instances.