[Merged by Bors] - feat(ring_theory/etale): Localization and formally etale homomorphisms. #15813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
erdOne
commented
Aug 2, 2022
erdOne
commented
erdOne
added
awaiting-review
jcommelin
reviewed
Aug 10, 2022
src/ring_theory/etale.lean
Outdated
Comment on lines
403
to
405
| /-- This actually does not need the localization instance, and is stated here again for | ||
| consistency. See `algebra.formally_unramified.of_comp` instead. -/ | ||
| @[nolint unused_arguments] |
There was a problem hiding this comment.
Can't you use an alias and avoid the unused_arguments?
There was a problem hiding this comment.
This is here so that one would not need to change anything (including removing redundant arguments) when copying proofs for formally_{unramified, smooth, etale}.
jcommelin
added
awaiting-author
erdOne
added
awaiting-review
|
✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with |
jcommelin
added
awaiting-author
leanprover-community-bot-assistant
added
the
delegated
Co-authored-by: Johan Commelin <johan@commelin.net>
|
bors r+ |
erdOne
removed
the
awaiting-author
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
…s. (#15813) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.