[Merged by Bors] - chore(data/seq/seq): use terminates predicate in to_list_or_stream
#15826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihdzp
added
easy
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Aug 3, 2022
Comment on lines
451
to
+452
| this is not constructively possible.) -/ | ||
| def to_list_or_stream (s : seq α) [decidable (∃ n, ¬ (nth s n).is_some)] : | ||
| list α ⊕ stream α := | ||
| if h : ∃ n, ¬ (nth s n).is_some | ||
| def to_list_or_stream (s : seq α) [decidable s.terminates] : list α ⊕ stream α := |
There was a problem hiding this comment.
It might be worth providing an instance along the lines of
instance [decidable (∃ n, ¬ (nth s n).is_some)] : decidable s.terminates :=but I guess if nothing uses this function anyway it's may best to leave it until an actual example appears.
There was a problem hiding this comment.
Yes, this is currently unused.
eric-wieser
reviewed
Aug 3, 2022
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
#15826) We already have a canonical way to spell out that a sequence terminates, so we don't need to spell it in full.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
terminates predicate in to_list_or_streamterminates predicate in to_list_or_stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a canonical way to spell out that a sequence terminates, so we don't need to spell it in full.