[Merged by Bors] - feat(data/seq/seq): prove seq.ext earlier
#15830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathlib-dependent-issues-bot
added
blocked-by-other-PR
|
This PR/issue depends on:
|
eric-wieser
added
awaiting-author
|
Can you merge master? |
vihdzp
added
awaiting-review
1 task
1 task
pechersky
reviewed
Aug 3, 2022
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
urkud
reviewed
Aug 15, 2022
urkud
reviewed
Aug 15, 2022
urkud
reviewed
Aug 15, 2022
urkud
reviewed
Aug 15, 2022
urkud
added
awaiting-author
vihdzp
removed
the
awaiting-author
vihdzp
added
the
awaiting-review
urkud
reviewed
Aug 24, 2022
| exact h.trans (nat.le_succ n) | ||
| end⟩ | ||
|
|
||
| instance coe_list : has_coe (list α) (seq α) := ⟨of_list⟩ |
There was a problem hiding this comment.
IMHO, it is strange to have both a function and a coercion. Which form is the simp-normal form? I would drop one of them.
|
OTOH, you don't change the API of |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
We heavily golf `seq.ext` and move it to almost the beginning of the file. Doing this breaks the proof of `seq.of_list_cons`, which we also change and golf by adding a few trivial `simp` lemmas (not all of them are needed, but might as well add them).
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
seq.ext earlierseq.ext earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We heavily golf
seq.extand move it to almost the beginning of the file. Doing this breaks the proof ofseq.of_list_cons, which we also change and golf by adding a few trivialsimplemmas (not all of them are needed, but might as well add them).consandtaildef-eqs #15829