[Merged by Bors] - feat(group_theory/group_action/defs): vadd_assoc_class
#15844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
fpvandoorn
reviewed
Aug 12, 2022
|
bors d+ |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
I think I got that right? Given that the queue is empty right now, let's give it a try. bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 12, 2022
Additivize `is_scalar_tower` into a new class `vadd_assoc_class`.
|
Build failed: |
|
Yep, that works. bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 12, 2022
Additivize `is_scalar_tower` into a new class `vadd_assoc_class`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
vadd_assoc_classvadd_assoc_class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additivize
is_scalar_towerinto a new classvadd_assoc_class.I need this to additivize properly results about
mul_action.stabilizerthat are themselves needed for Kneser's theorem (whose statement is usually given using additive notation, so I really can't do without this).vadd_assoc_classas a name doesn't really go withis_scalar_tower(what would?is_add_scalar_assoc_class?) but it does matchsmul_comm_classandvadd_comm_class. I already suggested renamingis_scalar_towertosmul_assoc_classon Zulip, and it would make even more sense after this PR.