Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/real/ennreal): deduplicate ennreal.nat_ne_top #15853

Closed
wants to merge 1 commit into from

Conversation

j-loreaux
Copy link
Collaborator

The lemmas ennreal.nat_ne_top and ennreal.coe_nat_ne_top are near duplicates, with the former being a simp lemma taking an explicit argument, and the latter being a non-simp lemma taking an implicit argument. The former is used slightly more frequently (in explicit form) in mathlib. We remove ennreal.coe_nat_ne_top in favor of ennreal.nat_ne_top.


Open in Gitpod

@j-loreaux j-loreaux added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Aug 4, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 4, 2022
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 8, 2022
bors bot pushed a commit that referenced this pull request Aug 8, 2022
The lemmas `ennreal.nat_ne_top` and `ennreal.coe_nat_ne_top` are near duplicates, with the former being a `simp` lemma taking an explicit argument, and the latter being a non-`simp` lemma taking an implicit argument. The former is used slightly more frequently (in explicit form) in mathlib. We remove `ennreal.coe_nat_ne_top` in favor of `ennreal.nat_ne_top`.
@bors
Copy link

bors bot commented Aug 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/real/ennreal): deduplicate ennreal.nat_ne_top [Merged by Bors] - chore(data/real/ennreal): deduplicate ennreal.nat_ne_top Aug 9, 2022
@bors bors bot closed this Aug 9, 2022
@bors bors bot deleted the j-loreaux/coe_nat_ne_top branch August 9, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants