feat(analysis/transcendental): e is transcendental #15954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruben-VandeVelde
added
the
awaiting-author
|
2k lines makes for a huge PR. I'd say anything above 300 is already large by mathlib standards. Is there any hope of splitting this off? |
vihdzp
requested changes
Aug 9, 2022
There was a problem hiding this comment.
This is just a high-level review of the analysis/transcendental/deriv.lean file. This could be moved to its own standalone PR. It should also be moved elsewhere, since none of those theorems have anything to do with transcendental numbers. I didn't review the proofs themselves nor attempted to golf them.
I also suggest you brand that file as proving results on the iterated derivative. I don't know if there's other files like that already (though I'd presume so).
|
|
||
| theorem transcendental_iff_transcendental_over_ℚ (x : ℝ) : | ||
| transcendental ℤ x ↔ transcendental ℚ x := | ||
| iff.not $ is_fraction_ring.is_algebraic_iff ℤ ℚ ℝ |
There was a problem hiding this comment.
Suggested change
| iff.not $ is_fraction_ring.is_algebraic_iff ℤ ℚ ℝ | |
| (is_fraction_ring.is_algebraic_iff ℤ ℚ ℝ).not |
alexjbest
reviewed
Aug 10, 2022
alexjbest
reviewed
Aug 10, 2022
semorrison
added
the
too-late
|
Obsoleted by leanprover-community/mathlib4#6718 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3884, second attempt.