Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/rat/cast): drop an unneeded typeclass assumption #15972

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(data/rat/cast): drop an unneeded typeclass assumption #15972

wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 10, 2022 •
edited

  • drop [char_zero _] assumption in map_rat_cast;
  • golf ring_hom.eq_rat_cast, generalize to ring_hom_class.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Aug 10, 2022
eric-wieser
eric-wieser reviewed Aug 10, 2022
View reviewed changes
src/data/rat/cast.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 10, 2022
@urkud urkud added awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-author A reviewer has asked the author a question or requested changes awaiting-review The author would like community review of the PR labels Aug 10, 2022
@urkud urkud added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 22, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Aug 22, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 22, 2022
bors bot pushed a commit that referenced this pull request Aug 22, 2022
@urkud
feat(data/rat/cast): drop an unneeded typeclass assumption (#15972)
6a5a2b1 
* drop `[char_zero _]` assumption in `map_rat_cast`;
* golf `ring_hom.eq_rat_cast`, generalize to `ring_hom_class`.
@bors
Copy link

bors bot commented Aug 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/rat/cast): drop an unneeded typeclass assumption [Merged by Bors] - feat(data/rat/cast): drop an unneeded typeclass assumption Aug 22, 2022
@bors bors bot closed this Aug 22, 2022
@bors bors bot deleted the YK-map-rat-cast branch August 22, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

@ericrbg ericrbg ericrbg left review comments

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@urkud @ocfnash @eric-wieser @jcommelin @ericrbg