Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(order/conditionally_complete_lattice): with_top.coe_infi and with_top.coe_supr #15975

Closed
wants to merge 6 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Aug 10, 2022

This adds infi and supr versions of the existing Inf and Sup lemmas, and adds some more general primed lemmas that work when much weaker assumptions are available on α.


Open in Gitpod

@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-order Order hierarchy labels Aug 10, 2022
@eric-wieser eric-wieser removed the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 10, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 10, 2022
Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/order/conditionally_complete_lattice.lean Outdated Show resolved Hide resolved
src/order/conditionally_complete_lattice.lean Outdated Show resolved Hide resolved
@ocfnash
Copy link
Collaborator

ocfnash commented Aug 11, 2022

bors d+

@bors
Copy link

bors bot commented Aug 11, 2022

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 11, 2022
Co-authored-by: Oliver Nash <github@olivernash.org>
@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 11, 2022
bors bot pushed a commit that referenced this pull request Aug 11, 2022
…`with_top.coe_supr` (#15975)

This adds `infi` and `supr` versions of the existing `Inf` and `Sup` lemmas, and adds some more general primed lemmas that work when much weaker assumptions are available on `α`.
@bors
Copy link

bors bot commented Aug 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/conditionally_complete_lattice): with_top.coe_infi and with_top.coe_supr [Merged by Bors] - chore(order/conditionally_complete_lattice): with_top.coe_infi and with_top.coe_supr Aug 11, 2022
@bors bors bot closed this Aug 11, 2022
@bors bors bot deleted the eric-wieser/with_top.coe_infi branch August 11, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants