Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(topology/constructions): review quotient API #15986

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - refactor(topology/constructions): review quotient API #15986

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 10, 2022

  • rename continuous_quotient_lift to continuous.quotient_lift;
  • rename continuous_quotient_lift_on' to continuous.quotient_lift_on';
  • add continuous.quotient_map' and use it to golf some proofs.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-topology Topological spaces, uniform spaces, metric spaces, filters labels Aug 10, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Aug 10, 2022
eric-wieser
eric-wieser approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks

src/topology/algebra/group.lean Outdated
{ exact @quotient.exists_rep _ (quotient_group.left_rel Γ) x },
change continuous (λ g, quotient_group.mk (g * g₀)),
exact continuous_coinduced_rng.comp (continuous_mul_right g₀)
rcases quotient_group.mk_surjective x with ⟨g₀, rfl⟩,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work too?

Suggested change
rcases quotient_group.mk_surjective x with ⟨g₀, rfl⟩,
induction x using quotient.induction_on,

src/topology/constructions.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Aug 11, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 11, 2022
urkud and others added 3 commits August 13, 2022 11:02
@urkud @eric-wieser
Update src/topology/constructions.lean
8b05dfb 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@urkud
Fix compile
056fce0
@urkud
Use induction
1ff859c
@urkud
Copy link
Member Author

urkud commented Aug 13, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 13, 2022
bors bot pushed a commit that referenced this pull request Aug 13, 2022
@urkud
refactor(topology/constructions): review quotient API (#15986)
31800d8 
* rename `continuous_quotient_lift` to `continuous.quotient_lift`;
* rename `continuous_quotient_lift_on'` to `continuous.quotient_lift_on'`;
* add `continuous.quotient_map'` and use it to golf some proofs.
@bors
Copy link

bors bot commented Aug 13, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(topology/constructions): review quotient API [Merged by Bors] - refactor(topology/constructions): review quotient API Aug 13, 2022
@bors bors bot closed this Aug 13, 2022
@bors bors bot deleted the YK-quot-map-golf branch August 13, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @eric-wieser @leanprover-community-bot-assistant