Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/algebra/uniform_group): add instance topological_group_is_uniform_of_compact_space #16027

Closed
wants to merge 3 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Aug 12, 2022

Also update doc string for topological_group.to_uniform_space.

cc @ADedecker


Open in Gitpod

…_is_uniform_of_compact_space`

Also update doc string for `topological_group.to_uniform_space`.
@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label Aug 12, 2022
Copy link
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

src/topology/algebra/uniform_group.lean Outdated Show resolved Hide resolved
src/topology/algebra/uniform_group.lean Show resolved Hide resolved
@ADedecker ADedecker added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Aug 15, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/topology/algebra/uniform_group.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Aug 15, 2022

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 15, 2022
@ocfnash
Copy link
Collaborator Author

ocfnash commented Aug 15, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 15, 2022
bors bot pushed a commit that referenced this pull request Aug 15, 2022
…_is_uniform_of_compact_space` (#16027)

Also update doc string for `topological_group.to_uniform_space`.

cc @ADedecker
@bors
Copy link

bors bot commented Aug 15, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 15, 2022
…_is_uniform_of_compact_space` (#16027)

Also update doc string for `topological_group.to_uniform_space`.

cc @ADedecker
@jcommelin
Copy link
Member

bors merge p=2

bors bot pushed a commit that referenced this pull request Aug 16, 2022
…_is_uniform_of_compact_space` (#16027)

Also update doc string for `topological_group.to_uniform_space`.

cc @ADedecker
@bors
Copy link

bors bot commented Aug 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/algebra/uniform_group): add instance topological_group_is_uniform_of_compact_space [Merged by Bors] - feat(topology/algebra/uniform_group): add instance topological_group_is_uniform_of_compact_space Aug 16, 2022
@bors bors bot closed this Aug 16, 2022
@bors bors bot deleted the ocfnash/compact_group_uniform branch August 16, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants