Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(polynomial/field_division): Add root_set_prod and clean up lemma statements #16035

Closed
wants to merge 2 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Aug 12, 2022

This PR adds root_set_prod (based on roots_prod) and cleans up lemma statements (the file already has {R S : Type*} [field R]).


Open in Gitpod

@tb65536 tb65536 added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Aug 12, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 15, 2022
bors bot pushed a commit that referenced this pull request Aug 15, 2022
…ma statements (#16035)

This PR adds `root_set_prod` (based on `roots_prod`) and cleans up lemma statements (the file already has `{R S : Type*} [field R]`).
@bors
Copy link

bors bot commented Aug 15, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 15, 2022
…ma statements (#16035)

This PR adds `root_set_prod` (based on `roots_prod`) and cleans up lemma statements (the file already has `{R S : Type*} [field R]`).
@jcommelin
Copy link
Member

bors merge p=3

@jcommelin
Copy link
Member

bors merge p=2

@bors
Copy link

bors bot commented Aug 15, 2022

Already running a review

bors bot pushed a commit that referenced this pull request Aug 15, 2022
…ma statements (#16035)

This PR adds `root_set_prod` (based on `roots_prod`) and cleans up lemma statements (the file already has `{R S : Type*} [field R]`).
@bors
Copy link

bors bot commented Aug 15, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 16, 2022
…ma statements (#16035)

This PR adds `root_set_prod` (based on `roots_prod`) and cleans up lemma statements (the file already has `{R S : Type*} [field R]`).
@bors
Copy link

bors bot commented Aug 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(polynomial/field_division): Add root_set_prod and clean up lemma statements [Merged by Bors] - feat(polynomial/field_division): Add root_set_prod and clean up lemma statements Aug 16, 2022
@bors bors bot closed this Aug 16, 2022
@bors bors bot deleted the root_set_prod branch August 16, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants