[Merged by Bors] - chore(algebra/algebra/unitization): update comm_semiring instance for unitization
#16048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-loreaux
added
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2022
…or `unitization` (#16048) The `comm_monoid` and `comm_semiring` instances for `unitization` had type class restrictions that were too strong because `non_unital_comm_semiring` didn't exist at the time `unitization` was created. This drops those restrictions.
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
comm_semiring instance for unitizationcomm_semiring instance for unitization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
comm_monoidandcomm_semiringinstances forunitizationhad type class restrictions that were too strong becausenon_unital_comm_semiringdidn't exist at the timeunitizationwas created. This drops those restrictions.