Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/separation): embedding.discrete_topology #16092

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(topology/separation): embedding.discrete_topology #16092

wants to merge 7 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Aug 17, 2022 •
edited

This PR adds a short lemma embedding.discrete_topology and golfs the related lemma discrete_topology_induced.

Open in Gitpod

@tb65536 tb65536 added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels Aug 17, 2022
@tb65536 tb65536 mentioned this pull request Aug 17, 2022
Closed
2 tasks
ADedecker
ADedecker reviewed Aug 17, 2022
View reviewed changes
src/topology/separation.lean Outdated Show resolved Hide resolved
src/topology/separation.lean Outdated Show resolved Hide resolved
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 17, 2022
tb65536
tb65536 commented Aug 18, 2022
View reviewed changes
src/topology/separation.lean Outdated Show resolved Hide resolved
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 18, 2022
ADedecker
ADedecker approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And sorry for being so picky 😅

src/topology/separation.lean Outdated Show resolved Hide resolved
src/topology/separation.lean Show resolved Hide resolved
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 19, 2022
tb65536
tb65536 commented Aug 19, 2022
View reviewed changes
src/topology/separation.lean Outdated Show resolved Hide resolved
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 19, 2022
@tb65536 tb65536 changed the title feat(topology/separation): inducing.discrete topology feat(topology/separation): embedding.discrete topology Aug 19, 2022
@jcommelin jcommelin changed the title feat(topology/separation): embedding.discrete topology feat(topology/separation): embedding.discrete_topology Sep 2, 2022
jcommelin
jcommelin approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 2, 2022
bors bot pushed a commit that referenced this pull request Sep 2, 2022
@tb65536
feat(topology/separation): embedding.discrete_topology (#16092)
c2023da 
This PR adds a short lemma `embedding.discrete_topology` and golfs the related lemma `discrete_topology_induced`.



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 2, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 2, 2022
@tb65536
feat(topology/separation): embedding.discrete_topology (#16092)
3c92748 
This PR adds a short lemma `embedding.discrete_topology` and golfs the related lemma `discrete_topology_induced`.



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 2, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/separation): embedding.discrete_topology [Merged by Bors] - feat(topology/separation): embedding.discrete_topology Sep 2, 2022
@bors bors bot closed this Sep 2, 2022
@bors bors bot deleted the inducing.discrete_topology branch September 2, 2022 13:27
b-mehta pushed a commit that referenced this pull request Sep 21, 2022
@tb65536 @b-mehta
feat(topology/separation): embedding.discrete_topology (#16092)
c64a95a 
This PR adds a short lemma `embedding.discrete_topology` and golfs the related lemma `discrete_topology_induced`.



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@ADedecker ADedecker ADedecker approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tb65536 @jcommelin @ADedecker @leanprover-community-bot-assistant