[Merged by Bors] - chore(data.matrix): rename minor to submatrix
#16101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✌️ abentkamp can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
the
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
As discussed on Zulip: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/matrix.2Eminor.20wrong.20terminology.3F This is an alternative to the previous plan to rename `minor` to `on` in #16063. Moreover, I have adapted some documentation in `src/linear_algebra/matrix/adjugate.lean` that also used the term "minor" in the wrong way.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
minor to submatrixminor to submatrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Zulip: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/matrix.2Eminor.20wrong.20terminology.3F
This is an alternative to the previous plan to rename
minortoonin #16063.Moreover, I have adapted some documentation in
src/linear_algebra/matrix/adjugate.leanthat also used the term "minor" in the wrong way.